Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression of PR#358 #375

Open
jorgeyanesdiez opened this issue Jul 20, 2022 · 2 comments
Open

Regression of PR#358 #375

jorgeyanesdiez opened this issue Jul 20, 2022 · 2 comments

Comments

@jorgeyanesdiez
Copy link
Contributor

Exactly the same problem fixed by PR#358 has happened again. And the same fix applies again.
Simply rebasing the commit and merging it again will fix the issue but, clearly it's not a long term solution.
Can we do something as suggested by @wez ? Is tools/update_all.py the correct location for a possible check/fix?

@mbadolato
Copy link
Owner

I haven't looked. It's either the update_all script, or the individual convert scripts may need to be told not to change the names to lowercase etc

@jdhmtl
Copy link
Collaborator

jdhmtl commented Aug 6, 2022

The files that standout from #357 appear to be matrix, darkmatrix, and darkermatrix. These are all lower case in the schemes directory, which I believe to be the source of truth. That being so, wouldn't the capitalized copies in the alacritty and vscode directories be incorrect? Would deleting those make the problem go away? Conversion scripts appear to be respecting casing, best I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants