New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid exposing internal token in the repo #55

Open

LautaroJayat opened this issue Jun 9, 2021 · 0 comments

LautaroJayat commented Jun 9, 2021

Noticed that internal token is exposed in this line:

loopback-component-realtime/src/drivers/io.driver.ts

Line 124 in b5c10dc

if (token.is === '-*!#fl1nter#!*-') {

it would be nice if the internal token could be injected as a configuration using the options parameter:

loopback-component-realtime/src/drivers/io.driver.ts

Line 23 in b5c10dc

connect(options?: OptionsInterface): any {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment