Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove device-specific hacks from fixup-mountpoints #204

Open
makinbacon21 opened this issue Jul 19, 2021 · 0 comments
Open

Please remove device-specific hacks from fixup-mountpoints #204

makinbacon21 opened this issue Jul 19, 2021 · 0 comments

Comments

@makinbacon21
Copy link

Adding device- or vendor-specific hacks to platform-agnostic repositories is poor form and detracts from code readability and interoperability. Device family common repos especially would have trouble with such a system. Device hacks should be written in from vendor or device repos--you may need to add a variable to facilitate this. I would recommend something like TARGET_HYBRIS_FSTAB, which could be set from a device-specific repo and provide device-specific fstab locations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant