Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement globbing #11

Open
Arcterus opened this issue Jul 3, 2018 · 2 comments
Open

Implement globbing #11

Arcterus opened this issue Jul 3, 2018 · 2 comments
Labels
enhancement New feature or request
Projects
sh

Comments

@Arcterus
Copy link
Contributor

Arcterus commented Jul 3, 2018

We cannot use the globwalk crate as it does not support globbing for parent directories (i.e. paths like ../../* won't work). We will probably need to roll our own directory walker, either by using globset or modifying glob to support OsStrings.
@Arcterus Arcterus added the enhancement New feature or request label Jul 3, 2018
@Arcterus Arcterus added this to Needs triage in sh via automation Jul 3, 2018
@Arcterus Arcterus moved this from Needs triage to High priority in sh Jul 3, 2018
@Arcterus
Copy link
Contributor Author

Arcterus commented Jul 4, 2018

I added support for non-UTF-8 filenames in glob, so I think we'll just use that. There are a couple of pull requests in the upstream repository that haven't been merged despite sitting there for a while, so we may want to fork the repository to merge in those changes.

@Arcterus Arcterus moved this from High priority to In Progress in sh Jul 6, 2018
@Arcterus
Copy link
Contributor Author

Arcterus commented Aug 2, 2018

This is also related to the IFS issue (#16) as we need to split the results of globbed expression based on IFS, so I will leave this open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
sh
  
In Progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Arcterus