Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a wrapper for splice() #40

Open
Arcterus opened this issue Jul 31, 2018 · 2 comments
Open

Add a wrapper for splice() #40

Arcterus opened this issue Jul 31, 2018 · 2 comments
Labels
enhancement New feature or request
Projects
sh

Comments

@Arcterus
Copy link
Contributor

On Linux, we should try to use splice() rather than the standard read/write stuff for operations involving pipes. This mostly affects sh.
@Arcterus Arcterus added the enhancement New feature or request label Jul 31, 2018
@Arcterus Arcterus added this to Needs triage in sh via automation Jul 31, 2018
@Arcterus
Copy link
Contributor Author

Depending on how far back we need to support we could use copy_file_range() for things as well (it doesn’t require one of the file descriptors to be a pipe, but it requires Linux 4.5).

@Arcterus
Copy link
Contributor Author

Arcterus commented Aug 3, 2018

It sounds like fs::copy() may already do this, so we might want to investigate a little more before deciding to add this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
sh
  
Needs triage
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Arcterus