Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Status #5

Open
chrisbroome opened this issue Sep 16, 2017 · 1 comment
Open

Project Status #5

chrisbroome opened this issue Sep 16, 2017 · 1 comment

Comments

@chrisbroome
Copy link

I just wanted to see what the status of this project is. I see that @geertbongers made some updates to recognize newer tags. I had actually made the same updates in my fork, but in a more intrusive manner. Specifically I did the following:

  • switched var to const and let in files I touched
  • switched test framework from nodeunit to Jest
  • remove usage of globals in /protocol/protocol.js in favor defining them as constants (in a new file, /protocol/packet.js) and and actually exporting them
  • added support for tag 0x27 (39) as lineup_url

At this point, I think it makes the most sense to merge @geertbongers/master changes to be merged first. After that, I can easily add the lineup_url changes in a way that keeps with the current style.

More long term, what are the plans for maintaining this repo? I personally would like to make some of the changes I listed above, but I'm not going to do that only to have the core repo change out from under me. I'd love to hear your thoughts on this.

Finally, thanks for all your hard work on this. You definitely did all the heavy lifting here.

@mharsch
Copy link
Owner

mharsch commented Sep 18, 2017

Feel free to make whatever changes you like, and I'll merge them. It may make sense in the long run to hand over ownership of the npm package if you're open to that. I don't have any plans to continue work on this project myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants