You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just wanted to see what the status of this project is. I see that @geertbongers made some updates to recognize newer tags. I had actually made the same updates in my fork, but in a more intrusive manner. Specifically I did the following:
remove usage of globals in /protocol/protocol.js in favor defining them as constants (in a new file, /protocol/packet.js) and and actually exporting them
added support for tag 0x27 (39) as lineup_url
At this point, I think it makes the most sense to merge @geertbongers/master changes to be merged first. After that, I can easily add the lineup_url changes in a way that keeps with the current style.
More long term, what are the plans for maintaining this repo? I personally would like to make some of the changes I listed above, but I'm not going to do that only to have the core repo change out from under me. I'd love to hear your thoughts on this.
Finally, thanks for all your hard work on this. You definitely did all the heavy lifting here.
The text was updated successfully, but these errors were encountered:
Feel free to make whatever changes you like, and I'll merge them. It may make sense in the long run to hand over ownership of the npm package if you're open to that. I don't have any plans to continue work on this project myself.
I just wanted to see what the status of this project is. I see that @geertbongers made some updates to recognize newer tags. I had actually made the same updates in my fork, but in a more intrusive manner. Specifically I did the following:
var
toconst
andlet
in files I touchedAt this point, I think it makes the most sense to merge @geertbongers/master changes to be merged first. After that, I can easily add the
lineup_url
changes in a way that keeps with the current style.More long term, what are the plans for maintaining this repo? I personally would like to make some of the changes I listed above, but I'm not going to do that only to have the core repo change out from under me. I'd love to hear your thoughts on this.
Finally, thanks for all your hard work on this. You definitely did all the heavy lifting here.
The text was updated successfully, but these errors were encountered: