Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Nest 7 #58

Open
michaelsogos opened this issue Nov 1, 2020 · 4 comments
Open

Update for Nest 7 #58

michaelsogos opened this issue Nov 1, 2020 · 4 comments

Comments

@michaelsogos
Copy link

Do you think is ok to update dependencies to nest 7.x ?

@michaelsogos
Copy link
Author

Hi @miaowing ,

Not a big issue, but each time i update a package with yarn it tell me:
nest-schedule@0.6.4" has incorrect peer dependency "@nestjs/common@^6.0.5".

It happens because i'm using NestJS 7.5.x 😄 .

Do you think is ok to update dependencies?

@hellohejinyu
Copy link

https://www.npmjs.com/package/@nestjs/schedule Why not try this.

@maxdietrich
Copy link

I opened a PR to update it (#63) since we have the same issue

@michaelsogos
Copy link
Author

I found that nestjs 7 and 8 have its own scheduler that work pretty similar. I changed my code to use the integrated one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants