Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RetryExhaustedOnAction and TimeoutOnAction strings accessible from Tree #26

Open
TravisOnGit opened this issue Aug 20, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@TravisOnGit
Copy link
Member

Instead of hard-coding "RetryExhaustedOnAction" and "TimeoutOnAction", let's add public const strings or enums so they are more accessible. They should be accessible through the tree/schema so users can easily check the ActionResponse.Status.

Possible solution is to add a new class to the parameters of the Roslyn script.

"ShouldSelect": "C#|(await Session.GetLastActionResponseAsync()).Status == FooEnums.TimeoutOnAction",

@TravisOnGit TravisOnGit added enhancement New feature or request good first issue Good for newcomers labels Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant