Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec for ParameterProperties is outdated #28395

Closed
ajafff opened this issue Nov 7, 2018 · 2 comments
Closed

spec for ParameterProperties is outdated #28395

ajafff opened this issue Nov 7, 2018 · 2 comments
Labels
Spec Issues related to the TypeScript language specification

Comments

@ajafff
Copy link
Contributor

ajafff commented Nov 7, 2018

https://github.com/Microsoft/TypeScript/blob/master/doc/spec.md#831-constructor-parameters:

A parameter of a ConstructorImplementation may be prefixed with a public, private, or protected modifier.

This is missing readonly.

A parameter property declaration may declare an optional parameter (by including a question mark or a default value), but the property introduced by such a declaration is always considered a required property

This is no longer true since the (not so) recent rewrite of the declaration emitter.

@weswigham weswigham added Bug A bug in TypeScript Spec Issues related to the TypeScript language specification labels Nov 7, 2018
@MartinJohns
Copy link
Contributor

The entire spec is outdated. The last real comit on it was nearly three years ago: https://github.com/Microsoft/TypeScript/commits/master/doc/spec.md

See also: https://github.com/Microsoft/TypeScript/issues?q=is%3Aopen+is%3Aissue+label%3ASpec
And mainly: #15711

@sheetalkamat sheetalkamat added this to the TypeScript 3.4.0 milestone Dec 8, 2018
@RyanCavanaugh RyanCavanaugh removed the Bug A bug in TypeScript label Mar 8, 2019
@RyanCavanaugh RyanCavanaugh removed this from the TypeScript 3.4.0 milestone Mar 8, 2019
@RyanCavanaugh
Copy link
Member

The spec is now an "archived" artifact and we won't be tracking defects against it anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spec Issues related to the TypeScript language specification
Projects
None yet
Development

No branches or pull requests

6 participants