Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript 5.4 Iteration Plan #56948

Open
DanielRosenwasser opened this issue Jan 4, 2024 · 35 comments
Open

TypeScript 5.4 Iteration Plan #56948

DanielRosenwasser opened this issue Jan 4, 2024 · 35 comments
Labels
Planning Iteration plans and roadmapping

Comments

@DanielRosenwasser
Copy link
Member

This document outlines our focused tasks for TypeScript 5.4. It minimally indicates intent to investigate tasks or contribute to an implementation. Nothing is set in stone, but we will strive to complete these tasks in a reasonable timeframe.

Date Event
2023-11-20 TypeScript 5.3 Release
2024-01-19 Create 5.4 Beta (5.4.0) Build for Testing
2024-01-23 TypeScript 5.4 Beta Release
2024-02-16 Create 5.4 RC (5.4.1) Build for Testing
2024-02-20 TypeScript 5.4 RC Release
2024-03-01 Create 5.4 Final (5.4.2) Build for Testing
2024-03-05 TypeScript 5.4 Final Release 🚀
gantt
    dateFormat  YYYY-MM-DD
    TypeScript 5.3 Stabilization Period : 2023-11-03, 2023-11-20
    TypeScript 5.4 Beta Development : 2023-11-03, 2024-01-19
    TypeScript 5.4 RC Development : 2024-01-20, 2024-02-16
    TypeScript 5.4 Stabilization Period : 2024-02-16, 2024-03-05
todayMarker stroke-width:5px,stroke:#0f0,opacity:0.5

Compiler and Language

Editor and Language Service

Performance

Website and Docs

Infrastructure

@DanielRosenwasser DanielRosenwasser added the Planning Iteration plans and roadmapping label Jan 4, 2024
@DanielRosenwasser DanielRosenwasser pinned this issue Jan 4, 2024
@DanielRosenwasser
Copy link
Member Author

@JoshuaKGoldberg
Copy link
Contributor

JoshuaKGoldberg commented Jan 4, 2024

This is one of the most exciting release points for us in typescript-eslint in a long time. Very high benefit here. Very much hoping there's no last-minute issue discovered. Thank you! 🙌

@zaguiini
Copy link

zaguiini commented Jan 7, 2024

Define Initial Sketch of LSP Support

It's not clear to me what this means. I thought TSC already was LSP-compliant?

@jakebailey
Copy link
Member

tsserver uses the tsserver protocol, which predates LSP. It does not (yet) implement LSP.

@guillaumebrunerie
Copy link

tsserver uses the tsserver protocol, which predates LSP. It does not (yet) implement LSP.

I've been using https://github.com/typescript-language-server/typescript-language-server#readme (a LSP implementation for TypeScript wrapping tsserver) with Emacs for quite some time and it works perfectly well, but I've never used tsserver directly so I'm not sure if there are any features that I'm missing.

Would a native implementation of LSP have any user-visible consequences, compared to using a wrapper like this one? Or is it mostly about supporting LSP officially and removing the need for a third-party wrapper?

@jakebailey
Copy link
Member

Would a native implementation of LSP have any user-visible consequences, compared to using a wrapper like this one? Or is it mostly about supporting LSP officially and removing the need for a third-party wrapper?

The latter, though there are of course other benefits.

@jfet97
Copy link
Contributor

jfet97 commented Jan 11, 2024

I'll share a link to Reverse mapped types with intersection constraint as well 😛, both for its enabling of type inference and Excess Property Checking together, and for doing some advertising for reverse mapped types, making @Andarist happy.

@DanielRosenwasser
Copy link
Member Author

@typescript-bot create release-5.4

@typescript-bot
Copy link
Collaborator

Heya @DanielRosenwasser, I've started to create the release-5.4 branch for you. Here's the link to my best guess at the log.

@DanielRosenwasser
Copy link
Member Author

Jake says he fixed the build.

@typescript-bot create release-5.4

@typescript-bot
Copy link
Collaborator

Heya @DanielRosenwasser, I've started to create the release-5.4 branch for you. Here's the link to my best guess at the log.

@dimitur2204
Copy link

dimitur2204 commented Jan 24, 2024

Finally!

@DanielRosenwasser
Copy link
Member Author

@typescript-bot sync release-5.4

@typescript-bot
Copy link
Collaborator

Heya @DanielRosenwasser, I've started to sync release-5.4 with main for you. Here's the link to my best guess at the log.

@DanielRosenwasser
Copy link
Member Author

Just as a heads up, we will probably go out with the 5.4 beta next Monday, since we're having some issues with the NuGet side of the build pipeline.

@DanielRosenwasser
Copy link
Member Author

@typescript-bot sync release-5.4

@typescript-bot
Copy link
Collaborator

Heya @DanielRosenwasser, I've started to sync release-5.4 with main for you. Here's the link to my best guess at the log.

@linbudu599
Copy link

Just as a heads up, we will probably go out with the 5.4 beta next Monday, since we're having some issues with the NuGet side of the build pipeline.

Also when are we probably going to see the devblog? Just be really excited to see it.

@DanielRosenwasser
Copy link
Member Author

5.4 Beta is now published:

@DanielRosenwasser
Copy link
Member Author

@typescript-bot sync release-5.4

@typescript-bot
Copy link
Collaborator

Heya @DanielRosenwasser, I've started to sync release-5.4 with main for you. Here's the link to my best guess at the log.

@DanielRosenwasser
Copy link
Member Author

@typescript-bot bump release-5.4

@typescript-bot
Copy link
Collaborator

Heya @DanielRosenwasser, I've started to update the version number on release-5.4 to 5.4.1-rc for you. Here's the link to my best guess at the log.

@ghiscoding
Copy link

@DanielRosenwasser is the v5.4 RC release still scheduled for today? I don't see it yet on NPM. Thanks

@DanielRosenwasser
Copy link
Member Author

No, unfortunately another issue with our build pipeline occurred. Otherwise, you can use the most recent nightly version of TypeScript to capture a (mostly?) identical version.

@crisbeto
Copy link

The previous comments mention an issue with the build pipeline around the RC release, but I now see a 5.4.1-rc release on npm. Would it be correct to assume that the 5.4 RC is out now?

@jakebailey
Copy link
Member

Yes: https://devblogs.microsoft.com/typescript/announcing-typescript-5-4-rc/

jpwilliams added a commit to inngest/inngest-js that referenced this issue Mar 1, 2024
## Summary
<!-- Succinctly describe your change, providing context, what you've
changed, and why. -->

Adds `typescript@rc` (currently `typescript@5.4.0`). This is used to
test the 5.4 release candidate to resolve any issues before it ships.
When it does, we'll move this PR to target `typescript@5.4.0` and merge,
including a changeset if any changes needed to be made.

We should ship this change once the final build is submitted at the
beginning of March. See microsoft/TypeScript#56948

## Checklist
<!-- Tick these items off as you progress. -->
<!-- If an item isn't applicable, ideally please strikeout the item by
wrapping it in "~~"" and suffix it with "N/A My reason for skipping
this." -->
<!-- e.g. "- [ ] ~~Added tests~~ N/A Only touches docs" -->

- [ ] ~Added a [docs PR](https://github.com/inngest/website) that
references this PR~ N/A
- [x] Added unit/integration tests
- [x] Added changesets if applicable

## Related

- microsoft/TypeScript#56948
@DanielRosenwasser
Copy link
Member Author

@typescript-bot bump release-5.4

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 4, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
bump release-5.4 ✅ Started ✅ Results

@typescript-bot
Copy link
Collaborator

Hey, @DanielRosenwasser! I've set the version of release-5.4 to 5.4.2 for you.

@RyanCavanaugh
Copy link
Member

@Anonymous4078 you ok?

@DanielRosenwasser
Copy link
Member Author

@typescript-bot bump release-5.4

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 15, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
bump release-5.4 ✅ Started ✅ Results

@typescript-bot
Copy link
Collaborator

Hey, @DanielRosenwasser! I've set the version of release-5.4 to 5.4.3 for you.

@DanielRosenwasser
Copy link
Member Author

DanielRosenwasser commented Mar 20, 2024

5.4.3 is out! https://github.com/microsoft/TypeScript/releases/tag/v5.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Planning Iteration plans and roadmapping
Projects
None yet
Development

No branches or pull requests