Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to Move ConfigurationBotFrameworkAuthentication from Microsoft.Bot.Builder.Integration.AspNet.Core to Microsoft.Bot.Connector #6735

Open
HiltonGiesenow opened this issue Jan 29, 2024 · 2 comments
Labels
feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team.

Comments

@HiltonGiesenow
Copy link
Contributor

HiltonGiesenow commented Jan 29, 2024

Is your feature request related to a problem? Please describe.
I'm working on other cloud hosting options for a bot, and would like to use ConfigurationBotFrameworkAuthentication, but I need to bring the entire Microsoft.Bot.Builder.Integration.AspNet.Core assembly along for the ride at the moment, just for this single class, which itself it not actually bound to anything AspNety at all.

Describe the solution you'd like
Based on the above, I'm requesting this be unbundled and moved into Microsoft.Bot.Connector, where it's base class BotFrameworkAuthentication lives. I'm happy to submit a PR for this, perhaps with some guidance if needed.

Describe alternatives you've considered
Right now, I'm creating a copy of ConfigurationBotFrameworkAuthentication in my new project.

Additional context
N/A

@HiltonGiesenow HiltonGiesenow added feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team. labels Jan 29, 2024
@tracyboehrer
Copy link
Member

@HiltonGiesenow Hmmm. Interesting request. My assumption was that this class, and the other Configuration* classes, were in Integration due to IConfiguration. I would not have expected them to work in Connector. The original goal was to avoid integration specific code in the "lower" layers since most of the stack is not integration specific. We'd need to do some research because my first question is why does it even build in Connector.

@HiltonGiesenow
Copy link
Contributor Author

Ah ok, I see what you mean. I guess maybe it depends on whether you classify IConfiguration as an 'Integration'? At the moment, now that I look more, it means there are classes that are practically 100% duplicated, for instance ConfigurationChannelProvider and ConfigurationCredentialProvider, between Microsoft.Bot.Builder.Integration.AspNet.WebApi and Microsoft.Bot.Builder.Integration.AspNet.Core, which is probably not ideal?

If it really makes sense to split IConfiguration-dependent elements out, perhaps there should be a Microsoft.Bot.Builder.Integration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
Development

No branches or pull requests

2 participants