Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures <li> elements are used semantically (li:nth-child(3)): A11y_WCP URLs - ONNX Runtime_AI4W #20261

Open
aniketr99 opened this issue Apr 10, 2024 · 1 comment
Assignees
Labels
documentation improvements or additions to documentation; typically submitted using template merge at green This PR can be merged when the CI is green. Please merge. platform:windows issues related to the Windows platform

Comments

@aniketr99
Copy link

aniketr99 commented Apr 10, 2024

GitHub Tags:

#A11ySev2; #A11yTCS; #DesktopWeb; #SH_ONNX Runtime & Ecosystem_Web_Mar2024; #ONNX Runtime & Ecosystem; #WCP; #Win11; #FTP; #P3_WCP; #ONNX Runtime; #ChromiumEdge; #A11yMAS; #WCAG1.3.1; #A11yAuto; #Info and relationships; #Accessibility; #listitem;

"Please do not close this bug. This bug should only be closed by TCS, C+AI Accessibility or the Divisional Driver".

Environment Details:

Application Name: WCP URLs - ONNX Runtime
URL: https://onnxruntime.ai/training
Edge version: 124.0.0.0 (Official build) (64-bit)
OS: Windows 11 version 23H2

Issue:

Ensures < li> elements are used semantically (listitem - https://accessibilityinsights.io/info-examples/web/listitem)

Target application:

ONNX Runtime | Training - https://onnxruntime.ai/training

Element path:

div[data-svelte-h="svelte-1fow8f8"] > li:nth-child(3)

Snippet:

< li>Image / Audio classification

How to fix:

Fix any of the following:

List item does not have a < ul>, < ol> parent element

Environment:

Microsoft Edge version 124.0.0.0

====

This accessibility issue was found using Accessibility Insights for Web 2.41.0 (axe-core 4.7.2), a tool that helps find and fix accessibility issues. Get more information & download this tool at http://aka.ms/AccessibilityInsights.

Attachment:

image

@github-actions github-actions bot added the platform:windows issues related to the Windows platform label Apr 10, 2024
@snnn snnn added documentation improvements or additions to documentation; typically submitted using template and removed platform:windows issues related to the Windows platform labels Apr 12, 2024
@MaanavD MaanavD self-assigned this Apr 15, 2024
@MaanavD MaanavD added the merge at green This PR can be merged when the CI is green. Please merge. label Apr 15, 2024
MaanavD added a commit that referenced this issue Apr 17, 2024
### Description
Made requested changes from Accessibility audit. Live at:
[maanavd.github.io/onnxruntime/](https://maanavd.github.io/onnxruntime/)



### Motivation and Context
Related issues addressed: 
#20259, #20261, #20263, #20264, #20096, #20100, #20101, #20102, #20103,
#20119, #20120, #20123

Co-authored-by: MaanavD <maanavdalal@microsoft.com>
MaanavD added a commit that referenced this issue Apr 29, 2024
### Description
Addresses #20096, and checked #20261 (should have already been fixed)

Also added a different animation for words on the hero as they didn't
look good (some svelte animation bug I think)

Link found at: https://maanavd.github.io/onnxruntime/

Co-authored-by: MaanavD <maanavdalal@microsoft.com>
@github-actions github-actions bot added the platform:windows issues related to the Windows platform label May 20, 2024
@PadminiGariki
Copy link

Verified the issue in below environment.
Application Name: WCP URLs - ONNX Runtime
URL: https://onnxruntime.ai/training
Edge version:125.0.2535.92 (Official build) (64-bit)
OS: Windows 11 version 23H2

Issue is fixed. Hence the bug is closed.
For reference attachment is added.

#Regressed:06-13-24; #Closed;

Attachment:

Screenshot 2024-06-13 121038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation improvements or additions to documentation; typically submitted using template merge at green This PR can be merged when the CI is green. Please merge. platform:windows issues related to the Windows platform
Projects
None yet
Development

No branches or pull requests

4 participants