Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Terminal]: 'Duplicate' button should remain in disabled state until user don't select a profile radio control. #12056

Closed
ghost opened this issue Dec 28, 2021 · 6 comments
Closed

[Terminal]: 'Duplicate' button should remain in disabled state until user don't select a profile radio control. #12056

ghost opened this issue Dec 28, 2021 · 6 comments
Labels
A11yCO Accessibility tracking A11yTTValidated Yet another label for the a11y folks. They want so many. So so many. A11yUsable Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Backlog

Comments

@ghost
Copy link

ghost commented Dec 28, 2021 •
edited by ghost

Windows Terminal version

1.12.3472.0

Windows build number

10.0.22504.1010

Other Software

Test Environment:
OS: Windows 11 Version Dev (OS Build 22504.1010)
App: Windows Terminal Preview
Screen Reader: Narrator

Steps to reproduce

Repro Steps:

  1. Open Windows Terminal.
  2. Open Settings page using 'Ctr+,'.
  3. Activate 'Add a new profile' tab and then navigate 'Duplicate' button.
  4. Observe the issue.

User Experience:
Users UX will not be good especially Screen Reader as nothing will happen when they activate 'Duplicate' button.

Attachments:
'Duplicate' button should remain in disabled state until user don't select a profile radio control..zip

Expected Behavior

'Duplicate' button should remain in disabled state until user don't select a profile radio control.

Actual Behavior

'Duplicate' button is in enabled state even when user don't select a profile radio control.

Note Issue: 'Save' and 'Discard' button should remain in disabled state until we don't make any changes.
@ghost ghost added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking A11yUsable Accessibility tracking HCL-WindowsTerminal Accessibility tracking A11yCO Accessibility tracking Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 28, 2021
@zadjii-msft zadjii-msft added the Product-Terminal The new Windows Terminal. label Jan 3, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 3, 2022
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, Backlog Jan 3, 2022
@zadjii-msft zadjii-msft added good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Priority-3 A description (P3) and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 5, 2022
@davidegiacometti davidegiacometti mentioned this issue Jan 5, 2022
Merged
6 tasks
@ghost ghost added In-PR This issue has a related PR and removed In-PR This issue has a related PR labels Jan 5, 2022
ghost pushed a commit that referenced this issue Jan 6, 2022
@davidegiacometti
Disable duplicate button without selected profile (#12096)
a766798 
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request

- Settings > Add a new profile
- Disable "Duplicate" button until a profile is selected

![Duplicate](https://user-images.githubusercontent.com/25966642/148303450-a084cd5f-7f1c-4de3-86bd-602b9336649e.gif)

<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> 
## References

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Should take care of #12056, once we can get a build to the a11y team (MAINTAINER EDIT: we unfortunately can't just say "closes #foo" for issues like this one, we need another team to validate the following build.)
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments

<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
DHowett pushed a commit that referenced this issue Jan 21, 2022
@davidegiacometti @DHowett
Disable duplicate button without selected profile (#12096)
b30137b 
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request

- Settings > Add a new profile
- Disable "Duplicate" button until a profile is selected

![Duplicate](https://user-images.githubusercontent.com/25966642/148303450-a084cd5f-7f1c-4de3-86bd-602b9336649e.gif)

<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? -->
## References

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Should take care of #12056, once we can get a build to the a11y team (MAINTAINER EDIT: we unfortunately can't just say "closes #foo" for issues like this one, we need another team to validate the following build.)
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments

<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed

(cherry picked from commit a766798)
@carlos-zamora carlos-zamora added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Feb 1, 2022
@rinkydevi
Copy link

hey @v-rpundir ! I would to contribute in this issue, how can i proceed ?

@zadjii-msft
Copy link
Member

@rinkydevi Sorry for the confusion here. This was actually already fixed in #12096 (and then we entirely changed this UI again in #12326 such that this was no longer an issue). There's just a bit of a delay between when a11y bugs are fixed and when we can close them out. I'll yank off the help wanted/easy starter tags, since that's confusing.

@v-rpundir can we confirm that this one is no longer an issue?

@zadjii-msft zadjii-msft removed Help Wanted We encourage anyone to jump in on these. good first issue This is a fix that might be easier for someone to do as a first contribution labels Feb 6, 2022
@rinkydevi
Copy link

@zadjii-msft thank u for your response sir!

@ghost
Copy link
Author

ghost commented Feb 7, 2022

@zadjii-msft Main issue is fixed but Note issue still repro.

Note Issue: 'Save' and 'Discard' button should remain in disabled state until we don't make any changes.

@zadjii-msft
Copy link
Member

@v-rpundir Ah okay. Missed that bit. That's actually quite a bit more complicated than disabling this one button till the user makes a selection. The Terminal doesn't have a good way to check when the user has actually made any changes via the UI. Also, the button will technically write out their settings to the file if they hit save even without changes. (I could have sworn there was a specific issue tracking this laying around but all I could find was a single bulletpoint in the #6800 megathread).

For tracking purposes, what do you think the best strategy is here?

  • file a new issue for a11y tracking of the save/discard bug?
  • wholly repurpose this thread to track that bug?

I'd rather not have two separate issues tracked in the same thread, so I just want to clarify a bit. Thanks!

@ghost
Copy link
Author

ghost commented Feb 8, 2022

@zadjii-msft Closing this bug as Main issue is fixed and logged new separate issue for Note #12424

@ghost ghost closed this as completed Feb 8, 2022
@DHowett DHowett added the A11yTTValidated Yet another label for the a11y folks. They want so many. So so many. label Jun 24, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A11yCO Accessibility tracking A11yTTValidated Yet another label for the a11y folks. They want so many. So so many. A11yUsable Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@DHowett @carlos-zamora @zadjii-msft @rinkydevi