Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.19 selfhost] URL autodetection is broken #15891

Closed
zadjii-msft opened this issue Aug 28, 2023 · 1 comment · Fixed by #15892
Closed

[1.19 selfhost] URL autodetection is broken #15891

zadjii-msft opened this issue Aug 28, 2023 · 1 comment · Fixed by #15892
Assignees
@lhecker
Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.19

Comments

@zadjii-msft
Copy link
Member

Version 1.19.2371.0, which I believe has #15858 in it.

Don't have a narrow repro yet - writing down before I forget.

I wrote a few screenfuls of text. Then did a git push. It gave me the handy:

Enumerating objects: 68, done.
Counting objects: 100% (68/68), done.
Delta compression using up to 8 threads
Compressing objects: 100% (41/41), done.
Writing objects: 100% (41/41), 4.62 KiB | 2.31 MiB/s, done.
Total 41 (delta 38), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (38/38), completed with 27 local objects.
remote:
remote: Create a pull request for 'dev/migrie/f/--inherit-env-vars' on GitHub by visiting:
remote:      https://github.com/microsoft/terminal/pull/new/dev/migrie/f/--inherit-env-vars
remote:
To https://github.com/microsoft/terminal
 * [new branch]          dev/migrie/f/--inherit-env-vars -> dev/migrie/f/--inherit-env-vars
Branch 'dev/migrie/f/--inherit-env-vars' set up to track remote branch 'dev/migrie/f/--inherit-env-vars' from 'origin'.

But alas, a ctrl+shift+m, shift+tab did not highlight the URL. Instead, it higlighted some text that was way up near the start of the buffer (but not like, as the same viewport-relative position or anything like that). The selected text was very much not a URL:

image
@zadjii-msft zadjii-msft added Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. labels Aug 28, 2023
@zadjii-msft zadjii-msft added this to the Terminal v1.19 milestone Aug 28, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 28, 2023
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 28, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 28, 2023
@lhecker
Copy link
Member

lhecker commented Aug 28, 2023

I have a fix on the way. 🙂

@lhecker lhecker mentioned this issue Aug 29, 2023
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Aug 29, 2023
lhecker added a commit that referenced this issue Aug 29, 2023
@lhecker
Fix pattern coordinates to be viewport relative (#15892)
d54ce33 
Pattern tree coordinates are viewport-relative.

Closes #15891

## Validation Steps Performed
* Print some text so the viewport scrolls down
* Print a URL
* URL is underlined on hover ✅
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lhecker lhecker

Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.19
Development

Successfully merging a pull request may close this issue.

Fix pattern coordinates to be viewport relative microsoft/terminal
2 participants
@lhecker @zadjii-msft