Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "Rename tab" action removes focus from terminal #9160

Closed
ArturGudiev opened this issue Feb 14, 2021 · 5 comments
Closed

The "Rename tab" action removes focus from terminal #9160

ArturGudiev opened this issue Feb 14, 2021 · 5 comments
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@ArturGudiev
Copy link

Environment

Windows 10.0.18363.0

Steps to reproduce

  1. Add the hotkey for the "rename tab" action in the settings
    { "command": "openTabRenamer", "keys": "ctrl+alt+r" },

  2. Rename a tab using this hotkey

Expected behavior

A tab is renamed. The focus is still in the terminal.

Actual behavior

A tab is renamed. The focus is on the tabs panel.

1
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 14, 2021
@Don-Vito
Copy link
Contributor

@ArturGudiev - I see you got the newer version in the end 😊
@zadjii-msft - actually the bug is wider, for some reason the focus doesn't return to the terminal, no mater if renamer is opened with shortcut or by clicking.

@Don-Vito Don-Vito mentioned this issue Feb 14, 2021
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Feb 14, 2021
@ArturGudiev
Copy link
Author

@Don-Vito Yes🙂
But I ran into this problem only when I pressed the hotkey.

@zadjii-msft
Copy link
Member

@Don-Vito Oh don't you worry, the problem is even wider. If you wanna be sad, go ahead and check out #6680

@zadjii-msft zadjii-msft mentioned this issue Feb 16, 2021
Closed
6 tasks
@ghost ghost removed the In-PR This issue has a related PR label Feb 17, 2021
@ghost ghost closed this as completed in 00d1dc9 Feb 17, 2021
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Feb 17, 2021
DHowett pushed a commit that referenced this issue Feb 23, 2021
@Don-Vito @DHowett
Teach tab to focus terminal after rename (#9162)
d33dd1f 
## Summary of the Pull Request
After rename ends (either by enter or escape) the rename box
gets collapsed and the focus moves to the next tab stop
in the TabView (e.g., new tab button).

To overcome this:
* Added RenameEnded event to TabHeaderControl
* Forwarded it as RenamerDeactivated from TerminalTab
* Registered in the TerminalPage to focus the active control upon
RenamerDeactivated if focus didn't move to tab menu.

This means, no matter how you close the renamer,
the current terminal gains the focus.

## PR Checklist
* [x] Closes #9160
* [x] CLA signed.
* [ ] Tests added/passed
* [ ] Documentation updated.
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already.

(cherry picked from commit 00d1dc9)
@ghost
Copy link

ghost commented Mar 1, 2021

🎉This issue was addressed in #9162, which has now been successfully released as Windows Terminal v1.6.10571.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Mar 1, 2021

🎉This issue was addressed in #9162, which has now been successfully released as Windows Terminal Preview v1.7.572.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ArturGudiev @Don-Vito @zadjii-msft