Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untie _UpdateCommandsForPalette and _RefreshUIForSettingsReload #9256

Open
zadjii-msft opened this issue Feb 23, 2021 · 0 comments
Open

Untie _UpdateCommandsForPalette and _RefreshUIForSettingsReload #9256

zadjii-msft opened this issue Feb 23, 2021 · 0 comments
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@zadjii-msft
Copy link
Member 

            // Make sure to _UpdateCommandsForPalette before
            // _RefreshUIForSettingsReload. _UpdateCommandsForPalette will make
            // sure the KeyChordText of Commands is updated, which needs to

Huh. Really. That's a weird dependency.

Please file a followup task to .. i dunno, make the settings model standalone or something? It seems like it still can't work without Page around :|

Originally posted by @DHowett in #9253 (comment)
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 23, 2021
@zadjii-msft zadjii-msft mentioned this issue Feb 23, 2021
Merged
@zadjii-msft zadjii-msft added Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Feb 24, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Feb 24, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Feb 24, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 26, 2021
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, Backlog Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@DHowett @zadjii-msft