Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large notebook trigger very many leak warnings #211112

Open
jrieken opened this issue Apr 23, 2024 · 1 comment
Open

Large notebook trigger very many leak warnings #211112

jrieken opened this issue Apr 23, 2024 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-toc-outline
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Apr 23, 2024

Testing #210961

slow.ipynb.txt

  • open dev tools console
  • open the notebook from above
  • 馃槺 notice leak warnings from various places

This is critical: REFUSES to accept new listeners because it exceeded its threshold by far because it means a listener will never be used, meaning a feature is likely not working.

This seems to be a widespread misconception and it seems each cell listens by itself. So, more cells, more listener, leak warning and refusal to accept more listeners. Generally, listener should be used sparingly, e.g instead of each cell being a listener there should be one per notebook which dispatches onto cell.

@amunger
Copy link
Contributor

amunger commented Apr 23, 2024

@DonJayamanne DonJayamanne removed their assignment Apr 23, 2024
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Apr 24, 2024
@VSCodeTriageBot VSCodeTriageBot added this to the April 2024 milestone Apr 24, 2024
@aeschli aeschli reopened this Apr 24, 2024
@VSCodeTriageBot VSCodeTriageBot removed the unreleased Patch has not yet been released in VS Code Insiders label Apr 24, 2024
@amunger amunger removed this from the April 2024 milestone Apr 24, 2024
@rebornix rebornix added this to the May 2024 milestone Apr 26, 2024
@Yoyokrazy Yoyokrazy added bug Issue identified by VS Code Team member as probable bug notebook-toc-outline labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug notebook-toc-outline
Projects
None yet
Development

No branches or pull requests

7 participants