Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SourceType to an Enum #4463

Open
Trenly opened this issue May 8, 2024 · 0 comments
Open

Move SourceType to an Enum #4463

Trenly opened this issue May 8, 2024 · 0 comments
Labels
Issue-Feature This is a feature request for the Windows Package Manager client.

Comments

@Trenly
Copy link
Contributor

Trenly commented May 8, 2024

Description of the new feature / enhancement

Currently source types are all either std::string or std::string_view in the code. To me, it seems like this isn't a very good way of ensuring the source types are well managed

Proposed technical implementation details

Refactor the code to use a SourceType enum with a method for converting to SourceType from a string or string_view, and a method for converting SourceType to string view. This can then be used for stronger argument validation on the source add command
@Trenly Trenly added the Issue-Feature This is a feature request for the Windows Package Manager client. label May 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage Issue need to be triaged label May 8, 2024
@denelon denelon removed the Needs-Triage Issue need to be triaged label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Trenly @denelon