additional regressor for prophet does not work

[sykrn]

The problem why additional regressor for prophet does not work due to these lines.
the regr object overrides the previous model with additional regressors.

    model = Prophet(**kwargs)
    for x in Xvars:
        model.add_regressor(x)
    regr = Prophet(**kwargs)
    regr.fit(X)
    fcst = regr.predict(p)

https://github.com/mikekeith52/scalecast/blob/1a8301784fcd60b07bb963896c83ca1ccdf244cd/src/scalecast/Forecaster.py#L561C1-L566C31

[mikekeith52]

Oof. That's a pretty egregious mistake on my part. I will have that fixed very soon, in the next release.

[sykrn]

Thanks @mikekeith52, waiting for the next release. :)

[mikekeith52]

Can I get you to review pull request #64? I confirmed that the code works but want to get your eyes on it to make sure there are no additional problems than what I was able to change.

[mikekeith52]

You should be able to upgrade to 0.18.11: pip install --upgrade scalecast

[mikekeith52]

Can we close this issue?