Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate allowed drop cells for clearly invalid cases #69

Closed
mikeperry-tor opened this issue Apr 15, 2021 · 1 comment
Closed

Eliminate allowed drop cells for clearly invalid cases #69

mikeperry-tor opened this issue Apr 15, 2021 · 1 comment

Comments

@mikeperry-tor
Copy link
Owner

In #37, we exempted some dropped cells due to various bugs in C Tor. These bugs still exist, and are unlikely to get fixed. Additionally, the bugs results in circuit failure anyway. There seems to be no reason to actually allow these cells, as these cases can also be a point to inject a dropped cell and not have the circuit get closed.

We should just demote the log to INFO and close the circuit anyway.
mikeperry-tor pushed a commit that referenced this issue Apr 15, 2021
Issue #69: Remove exemptions for all dropped cells.
d724e14 
Let's just close the circ and log at info. These will never be fixed in C Tor,
and they are broken behavior anyway.
@mikeperry-tor
Copy link
Owner Author

Included in changelog and fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikeperry-tor