Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hw1 quantize check #30

Open
zmoon opened this issue Sep 15, 2020 · 1 comment
Open

hw1 quantize check #30

zmoon opened this issue Sep 15, 2020 · 1 comment

Comments

@zmoon
Copy link

zmoon commented Sep 15, 2020

I feel like the check might be inadequate?

https://github.com/mitmath/18S191/blob/123040947d5b03a572b58c261b3009c8041b5c4e/homework/homework1/hw1.jl#L986-L1000

Since it is checking 0.3, floor with any digits ≥ 1 will pass, when really we want digits=1.
@fonsp
Copy link
Member

fonsp commented Sep 20, 2020

Yep! Feel free to open a PR

@musabkilic musabkilic mentioned this issue Sep 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fonsp @zmoon