Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1244 #1250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #1244 #1250

wants to merge 1 commit into from

Conversation

arjunsuresh
Copy link
Contributor

Fix "--branch" for cm pull repo

@arjunsuresh
Fix #1244
00215ef 
Fix "--branch" for cm pull repo
@arjunsuresh arjunsuresh requested a review from a team as a code owner May 7, 2024 11:01
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

gfursin
gfursin reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@gfursin gfursin left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think "&&" will not work on Windows ... It's a core functionality and we should make sure that it works on all platforms.

@arjunsuresh
Copy link
Contributor Author

I think it works on new shells on Windows. This feature is currently broken in CM. So needs to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfursin gfursin gfursin left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arjunsuresh @gfursin