Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tensor rotation #146

Open
mlund opened this issue Jun 11, 2019 · 1 comment
Open

Tensor rotation #146

mlund opened this issue Jun 11, 2019 · 1 comment
Labels
code quality ⚙️ Code refactoring / restructuring
Milestone
future revision

Comments

@mlund
Copy link
Owner

mlund commented Jun 11, 2019 •
edited

Tensors (see particle.cpp) are currently rotated using a rotation matrix. It would be more efficient to change this to quaternions as is done for vectors (now particle rotation functions required both matrix and quaternion). Eigen transformations.

ping @bjornstenqvist
@mlund mlund added this to the future release milestone Jul 2, 2019
@mlund
Copy link
Owner Author

mlund commented Jul 25, 2019

Eigen now seems to have experimental tensor support: http://eigen.tuxfamily.org/index.php?title=Tensor_support

@mlund mlund added code quality ⚙️ Code refactoring / restructuring and removed enhancement 💪 labels Dec 25, 2019
@mlund mlund modified the milestones: Version 2.4.0, future revision Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality ⚙️ Code refactoring / restructuring
Projects
None yet
Milestone
future revision
Development

No branches or pull requests
1 participant
@mlund