Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoleculeInserter implementations #270

Open
rc83 opened this issue Apr 23, 2020 · 0 comments
Open

MoleculeInserter implementations #270

rc83 opened this issue Apr 23, 2020 · 0 comments

Comments

@rc83
Copy link
Collaborator

rc83 commented Apr 23, 2020

Currently, only RandomInserter is implemented, that places molecules at random positions in the simulation box (also allowing random rotations). Another useful strategy would be to place molecules at positions that are read from a file, e.g., xyz or gro.

In the yaml/json configuration, the inserter attributes are now inappropriately and confusingly part of the molecule attributes. They should be move to the insertmolecules section.

Insertion of atomic molecules is quite straightforward. The positions are read from a file line by line where atom names match. When the coordinates need to wrap around the PBC, a warning is issued.

Insertion of complex molecules can be done similarly. It is presumed that the order of atoms (after any unknown atoms are filtered out) corresponds to the topology of the molecule. If a mismatch in atom order is found, an error shall be raised. This also means that the structure of the molecule provided in the molecule configuration will not be used at all as the structure is described here directly by the atoms positions.
(In the future, an alternative description of molecule placement could be considered: COM position and orientation vector.)

Comments are welcome.
Related to #268.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant