Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Healthcheck start interval into its own default value as per docs #47648

Open
saltydk opened this issue Mar 28, 2024 · 4 comments
Open
Labels
area/daemon exp/beginner kind/bugfix PR's that fix bugs kind/feature Functionality or other elements that the project doesn't currently have. Features are new and shiny
Milestone

Comments

@saltydk
Copy link

saltydk commented Mar 28, 2024

Description

Is there a particular reason that the start interval inherits the value from regular interval?

moby/daemon/health.go

Lines 253 to 255 in a33b302

probeInterval := timeoutWithDefault(c.Config.Healthcheck.Interval, defaultProbeInterval)
startInterval := timeoutWithDefault(c.Config.Healthcheck.StartInterval, probeInterval)
startPeriod := timeoutWithDefault(c.Config.Healthcheck.StartPeriod, defaultStartPeriod)

Docs indicate that the default is 5 seconds: https://docs.docker.com/reference/dockerfile/#healthcheck

This request is to have it defined as its own default value as per the docs.

I apologize if I have misread the code as I am not a Golang programmer.

@saltydk saltydk added kind/feature Functionality or other elements that the project doesn't currently have. Features are new and shiny status/0-triage labels Mar 28, 2024
@neersighted
Copy link
Member

cc @cpuguy83

@cpuguy83
Copy link
Member

I think this was just an oversight.

@vvoland vvoland added this to the 27.0.0 milestone Apr 24, 2024
@j2walker
Copy link

j2walker commented May 1, 2024

Hi @vvoland, I am a student from UT Austin taking a class about virtualization and containerization (CS 360V). Could I tackle this bug fix?

@cpuguy83
Copy link
Member

cpuguy83 commented May 4, 2024

Please do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/daemon exp/beginner kind/bugfix PR's that fix bugs kind/feature Functionality or other elements that the project doesn't currently have. Features are new and shiny
Projects
None yet
Development

No branches or pull requests

5 participants