Use Timeout.timeout instead of Object#timeout #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change suppresses the following warning: ``` warning: Object#timeout is deprecated, use Timeout.timeout instead. ```
|
|
|
o god... i have company here... i am facing that exact problem |
|
% docker run --rm -ti ruby:3.0.2
irb(main):001:0> RUBY_VERSION
=> "3.0.2"
irb(main):002:0> timeout(1) {}
(irb):2: warning: Object#timeout is deprecated, use Timeout.timeout instead.
=> nil
irb(main):003:0> But if timeout gem is updated to 0.2.0 or later % docker run --rm -ti ruby:3.0.2 /bin/bash
root@f74035cc99bc:/# gem install timeout
Fetching timeout-0.3.0.gem
Successfully installed timeout-0.3.0
1 gem installed
root@f74035cc99bc:/# irb
irb(main):001:0> RUBY_VERSION
=> "3.0.2"
irb(main):002:0> timeout(1) {}
(irb):2:in `<main>': undefined method `timeout' for main:Object (NoMethodError)
from /usr/local/lib/ruby/gems/3.0.0/gems/irb-1.3.5/exe/irb:11:in `<top (required)>'
from /usr/local/bin/irb:23:in `load'
from /usr/local/bin/irb:23:in `<main>'
irb(main):003:0> @mishina2228 Did you update timeout gem? Anyway, to run god with ruby 3.1+, this PR is necessary. |
|
@minimum2scp Ah, you're right! I was using Thanks for pointing out and explaining in detail! |
vishnu-thayyil
approved these changes
Oct 17, 2022
stanimal
added a commit
to jewlr/god
that referenced
this pull request
Jul 4, 2023
heridev
added a commit
to heridev/god_timeout_compatible
that referenced
this pull request
Oct 27, 2023
|
+1 on needing this |
|
+1 as its a need now |
|
+1 as it's needed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #263.
This change suppresses the following warning on Ruby 2.7: