Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devguides: add subtract_fee_from_outputs to wallet-rpc transfer #2249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

plowsof
Copy link
Contributor

@plowsof plowsof commented Feb 25, 2024

blocked until next release

closes #2248

Copy link

netlify bot commented Feb 25, 2024

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f6c6e86
🔍 Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/664cacb21938f600084e0b29
😎 Deploy Preview https://deploy-preview-2249--barolo-time-757cf9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jeffro256
Copy link
Contributor

The word "proportionally" here might be misleading. The feature splits the fee evenly between the destinations flatly, i.e. regardless of destination amount.

@plowsof
Copy link
Contributor Author

plowsof commented May 18, 2024

Thanks @jeffro256, something like this: ?

The fee will be subtracted evenly from each destination (regardless of amount).

Thoughts on this warning or is it dumb

Do not use this if recipient requires an exact amount.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

devguides: wallet-rpc transfer amount with fee included missing
2 participants