Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyword arguments for options #175

Open
asppsa opened this issue Apr 26, 2020 · 2 comments
Open

Keyword arguments for options #175

asppsa opened this issue Apr 26, 2020 · 2 comments
Labels

Comments

@asppsa
Copy link
Collaborator

asppsa commented Apr 26, 2020

Moneta's convention of using a hash as the last argument for most methods in order to pass in options has been deprecated in Ruby 2.7, and won't be supported at all in 3.0. As such, we should change the Moneta spec and the code to use keyword arguments for options instead.

@terceiro
Copy link
Contributor

so there are problems in the code as well in ruby3.0? I was thinking it was just a test suite issue

@asppsa
Copy link
Collaborator Author

asppsa commented Nov 24, 2021

Yes, it's a problem across the package at present - you'll see a lot of options = {} at the end of function definitions. We'll need to go through and change these all to **options and then work out what breaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants