Return Time::BSON_TYPE for Date and DateTime instances #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rialised inside hashes and arrays
… BSON_TYPE constant
durran
added a commit
that referenced
this pull request
Feb 18, 2014
Return Time::BSON_TYPE for Date and DateTime instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows Date and DateTime objects to be serialised as BSON when inside Hash and Array objects.
Currently, the following produces a NoMethodError:
{ date: Date.today }.to_bsonInstances of Date (and by extension DateTime) do not respond to
bson_type, but do convert to Time objects when serialised directly. Mapping these instances as part of an Array or Hash does require these to respond tobson_type, and so to fix this, I've defined abson_typemethod on Date (inherited by DateTime) which returns the value ofTime::BSON_TYPE.This is, as you might imagine, largely an itch-scratching PR. If this logic is better suited to my application, let me know!