Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use respond_to? everywhere we use method_missing #633

Open
smtlaissezfaire opened this issue Jan 18, 2016 · 1 comment
Open

Use respond_to? everywhere we use method_missing #633

smtlaissezfaire opened this issue Jan 18, 2016 · 1 comment

Comments

@smtlaissezfaire
Copy link
Member

All of the method_missing stuff is confusing (and doesn't perform well). We should also be overriding respond_to? anytime we override method_missing

@cheald
Copy link
Member

cheald commented Jan 20, 2016

method_missing is used to provide access to dynamic keys on documents (ie, in the case when a key is present in a document, but wasn't declared on the model directly). How would respond_to? be helpful here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants