Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the load of default config file with alias based on latest psych #726

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix the load of default config file with alias based on latest psych #726

wants to merge 1 commit into from

Conversation

brunoarueira
Copy link

Fixes #725

@brunoarueira brunoarueira mentioned this pull request Apr 25, 2024
Merged
@smtlaissezfaire
Copy link
Member

smtlaissezfaire commented Apr 26, 2024 •
edited

Seems fine to me assuming PR tests pass.

@smtlaissezfaire
Copy link
Member

Should probably also do a tiny version release

@brunoarueira
Copy link
Author

hey @smtlaissezfaire , do you know any way to test a rails engine initializer like we have here? I've search around and did not found anything.

@smtlaissezfaire
Copy link
Member

hey @smtlaissezfaire , do you know any way to test a rails engine initializer like we have here? I've search around and did not found anything.

Not sure off hand; we could look at rcov to see if it's actually getting run.

And/or we could also extract the code into a method and test that directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@brunoarueira @smtlaissezfaire