Skip to content

Commit d6714f3

Browse files
committed
MDL-86596 Profiling: add breadcrumb node to profiling detail page
Boost theme removes the last item action. This adds an extra node so the profile run details page breadcrumb is clickable in both Classic and Boost themes.
1 parent 11db03e commit d6714f3

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

admin/tool/profiling/index.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,9 @@
5252
}
5353

5454
// Add a new nav item to make $listurl clickable for the Boost theme.
55-
if (isset($script)) {
56-
$lastrunnav = get_string('lastrun', 'tool_profiling');
57-
$PAGE->navbar->add($lastrunnav);
55+
if (isset($script) || isset($runid)) {
56+
$detailnav = get_string('detailview', 'tool_profiling');
57+
$PAGE->navbar->add($detailnav);
5858
}
5959

6060
// Header

admin/tool/profiling/lang/en/tool_profiling.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
$string['cannotfindanyrunforrunid'] = 'Sorry, cannot find the \'{$a}\' profiling run';
3232
$string['comment'] = 'Comment';
3333
$string['cputime'] = 'CPU time';
34+
$string['detailview'] = 'Summary of run';
3435
$string['differencesbetween2runsof'] = 'Differences between 2 runs of {$a}';
3536
$string['executiontime'] = 'Execution time';
3637
$string['export'] = 'Export';
@@ -41,7 +42,6 @@
4142
$string['importprefix'] = 'Import prefix';
4243
$string['importproblem'] = 'Some problem happened importing the file "{$a}".';
4344
$string['lastrunof'] = 'Summary of last run of {$a}';
44-
$string['lastrun'] = 'Summary of last run';
4545
$string['markreferencerun'] = 'Mark as reference run/comment';
4646
$string['memory'] = 'Memory used';
4747
$string['pluginname'] = 'Profiling runs';

0 commit comments

Comments
 (0)