Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security vulnerability / hardening #1207

Open
Knoxi-Code opened this issue Jan 19, 2024 · 4 comments
Open

Security vulnerability / hardening #1207

Knoxi-Code opened this issue Jan 19, 2024 · 4 comments

Comments

@Knoxi-Code
Copy link

Knoxi-Code commented Jan 19, 2024

My application monitoring see that Firefox joining tcp 127.0.01 lochost, port 30035, this is the same port for the moolticut communication between mooltipass and moolticut.
At the first moment i thinking it was the communcation between mooltipass and firefox extension, but it wasent, a application that communicate out of a system and join the the port that transfer the crypted passwords between manager and device, can be a MIT attck to snif data!

If the firefox extension need over tcp lochost let they communicate over a other port, not the same port that communicate with the moolticut.app too. This prevent when the browser is okjupied, that not in the same commuication port between manager.app and device to prevent a MIT attack.

Debian 12
I love your work,
keep it up :)

@limpkin
Copy link
Collaborator

limpkin commented Jan 19, 2024

hello,
I'm very sorry but I don't understand your issue... could you rephrase?

@Jan-NiklasB
Copy link

If I get it right Knoxi-Code states, that the communication between the moolticute and the mooltipass uses the same port as the communication between moolticute and the browser extension.
He thinks that it could open the possibility of a Man in the Middle attack by sniffing the port.

Is that right @Knoxi-Code?

@Knoxi-Code
Copy link
Author

Sorry that I'm only getting in touch now :)

@Jan-NiklasB yes that the point, this is the first time I have seen this.

The problem is that it is possible to hide code within an application using code injection or code migration. Now there is hardly any reason why Firefox should access the same port, that use moolticut to comunicate with the device.

or is the connection form firefox to the port 30035, from the firefox extension ?
If so, wouldn't it be safer to run them via a different port ?

@limpkin
Copy link
Collaborator

limpkin commented Apr 21, 2024

I apologize for my delayed answer...
We're basically using a daemon listening to port 30035, which listens to communications coming from either moolticute GUI or the extensions. Any program can therefore communicate with it.
The data flow is Mooltipass to daemon through USB then daemon to client through local networking... so I'm still not sure what the potential issue would be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants