Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building from source release displays git as version number #1225

Open
Drakx opened this issue May 21, 2024 · 2 comments
Open

Building from source release displays git as version number #1225

Drakx opened this issue May 21, 2024 · 2 comments

Comments

@Drakx
Copy link
Contributor

Drakx commented May 21, 2024

Expected behaviour

Display the correct version number as release tag indicates under About
Version: 1.03.0

Actual behaviour

Download https://github.com/mooltipass/moolticute/archive/refs/tags/v1.03.0.zip and build according to instructions.
Start Moolticute
Navigate to About
Version: git

Moolticute Version

1.03.0 release

Operating System

Void Linux

Mooltipass Device

The Mooltipass Mini BLE

@limpkin
Copy link
Collaborator

limpkin commented May 21, 2024

oh that's a tough one... I'm not sure how we could go about checking if a given download zip file matches the contents of a given release

@Drakx
Copy link
Contributor Author

Drakx commented Jun 2, 2024

@limpkin I wouldn't think that's a solution, rather there would be a version somewhere in the code, that when building would display whatever version was used when building. I've not gone through to check. It's not an issue that the version shows git more of an annoyance after building a release like the one listed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants