Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing apostrophe in yaml #171

Open
jayvdb opened this issue Jan 17, 2019 · 0 comments
Open

Trailing apostrophe in yaml #171

jayvdb opened this issue Jan 17, 2019 · 0 comments
Projects
Milestone

Comments

@jayvdb
Copy link
Member

jayvdb commented Jan 17, 2019

An interesting problem encountered, the following is considered valid yaml by the currently yaml loader.

configuration:
  configuration: .moban.yaml
  template_dir:
    - ../docker-mobans/.moban.dt/'

The result is the trailing ' causes the directory to not be found, and the error message is a bit confusing as the apostrophe looks like it is closing a opening apostrophe, as error messages often do put literal strings in quotes.

Error: /home/jayvdb/projects/django-mobans/docker-mobans/.moban.dt/' does not exist

This should be checked with PyYaml to see if it detects it as a yaml error, and also check with the spec whether it should be valid. It may be an upstream bug in yaml parsers.

If it is valid everywhere, it is worth a special error message from moban.

The reason I encountered it is because I was switching between remote requires: and local directory version as described in #170 .

@jayvdb jayvdb added this to the 0.5.0 milestone Jan 24, 2019
@chfw chfw added this to back-log in 0.7.x Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
0.7.x
back-log
Development

No branches or pull requests

2 participants