Discontinuous Lines #116
Merged
Discontinuous Lines #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted by no line rather than a line connecting only the coords with data.
|
IMHO, the ideal behaviour would be:
To maintain backwards compatibility, this new behaviour will need to be off by default. At the next major release we can drop the old behaviour though, since this is far more sensible. I'd like to get some pretty comprehensive unit tests around this feature before merging too. I've created a branch (broken-lines) in my repo to work on this. |
|
submitted a pull request to the broken-lines branch... cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a data set is [{y: 1}, {y: null}, {y: 3}, {y: 4}] then the graph should only draw a line between 3 and 4. This is for cases where the absence of data is visually important.
A configuration called 'continuousLine' is default to false. If continuousLine is set to true, the graph should draw a line from 1 to 3 to 4, which is the current behavior.