Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line Chart with Fill #199

Closed
kazzkiq opened this issue Mar 19, 2013 · 2 comments
Closed

Line Chart with Fill #199

kazzkiq opened this issue Mar 19, 2013 · 2 comments

Comments

@kazzkiq
Copy link

kazzkiq commented Mar 19, 2013

Hello there,

back then, when no area chart exists, i saw a lot of posts claiming for "area-like" charts, where you have lines and a fill bellow them. This posts became more and more popular, until @oesmith implemented these area charts.

But area charts don't behave like lines, they are cumulative, wich means that if i have two lines with the value: 20, they don't stay one behind other, but one above other.

I think that this is the purpose of area charts, but there should be a way to enable/disable cumulative lines, to use it as line charts with fill.

I will put a image here to illustrate what i mean:

zeb

What do you guys think?

@oesmith
Copy link
Contributor

oesmith commented Mar 31, 2013

This isn't something that you can do at the moment with Morris, however it
shouldn't be terribly difficult to implement. It's just a slightly
different line drawing behaviour for the line chart class.

I'll leave this open as a suggestion. Pull requests welcome!
On Tue, Mar 19, 2013 at 9:13 PM, Claudio Holanda Jr. <
notifications@github.com> wrote:

Hello there,

back then, when no area chart exists, i saw a lot of posts claiming for
"area-like" charts, where you have lines and a fill bellow them. This posts
became more and more popular, until @oesmith https://github.com/oesmithimplemented these area charts.

But area charts don't behave like lines, they are cumulative, wich means
that if i have two lines with the value: 20, they don't stay one behind
other, but one above other.

I think that this is the purpose of area charts, but there should be a way
to enable/disable cumulative lines, to use it as line charts with fill.

I will put a image here to illustrate what i mean:

[image: zeb]https://f.cloud.github.com/assets/1953194/277998/382cbe48-90d9-11e2-8dc6-b769028dfd0b.png

What do you guys think? Can this be achieved easily?


Reply to this email directly or view it on GitHubhttps://github.com/oesmith/morris.js/issues/199
.

tiraeth pushed a commit to tiraeth/morris.js that referenced this issue Mar 31, 2013
…d morris.line to separate line and point draw operation
@kazzkiq
Copy link
Author

kazzkiq commented Apr 1, 2013

It seems like @tiraeth's solution (#205) made it very well, thanks!

@kazzkiq kazzkiq closed this as completed Apr 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants