Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fulfillment: Keys for checkboxes should be order ID, not zero-indexed #153

Open
joeholdcroft opened this issue Dec 4, 2013 · 0 comments

Comments

@joeholdcroft
Copy link
Contributor

Currently in fulfillment the keys for the checkboxes (and also the orders) are just zero-indexed. I think there was a reason for this, something to do with Symfony form.

However this is dangerous because it assumed the keys for the orders array and the checkboxes (same for dispatch checkbox listings like post/pick-up) have the same indexes.

This recently caused an issue when we started filtering out orders and the keys now had gaps.

The fix would be to always have the keys as the order ID so there was never a chance of the wrong order being changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant