Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor server switching in the controller #9478

Open
data-sync-user opened this issue May 2, 2024 · 0 comments
Open

Refactor server switching in the controller #9478

data-sync-user opened this issue May 2, 2024 · 0 comments

Comments

@data-sync-user
Copy link
Collaborator

Currently, server switching (silent or user-initiated) results in sending a deactivate signal to the platform-specific controller, followed by an activate signal. However, for all platforms (except possibly flatpaks), the deactivate is a no-op. This is confusing, and has tripped up many people interpreting this code. Additionally, using the activate signal for a config switch (to a new tunnel) is responsible for an entire class of bugs.

We should add a new controller function for server switches, streamlining this code.

┆Issue is synchronized with this Jira Task
┆Reporter: Matt Cleinman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant