Reduce menu dropdowns #14484
Reduce menu dropdowns #14484
Conversation
| {% if mozilla_monitor %} | ||
| <h4 class="c-menu-item-title">{{ ftl('navigation-v2-mozilla-monitor', fallback='navigation-v2-firefox-monitor') }}</h4> | ||
| {% else %} | ||
| <h4 class="c-menu-item-title">{{ ftl('navigation-v2-firefox-monitor', fallback='navigation-firefox-monitor') }}</h4> |
There was a problem hiding this comment.
Suggestion: Now that we're using the new Mozilla Monitor string here, feel free to remove the (now obsolete) navigation-v2-firefox-monitor string from the navigation_v2.ftl file :) since it's been (much) more than 2 months (referencing the new rule we implemented of us deciding to remove obsolete strings from our codebase after ~2 months) from when we implemented the new string!
There was a problem hiding this comment.
👍 Makes sense. I felt the nav is rather "sensitive" to do any cleanups but after wandering around the locales I see the typical pattern: whenever the default string is used, it's amid of 80% untranslated elements in English anyways. And for a branding change, it's way better to have a fresh default, than an outdated name, even if localised. You got it.
bedrock/base/templates/includes/protocol/navigation/menus/products.html
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14484 +/- ##
=======================================
Coverage 76.44% 76.44%
=======================================
Files 148 148
Lines 7977 7978 +1
=======================================
+ Hits 6098 6099 +1
Misses 1879 1879 ☔ View full report in Codecov by Sentry. |
One-line summary
With upcoming sunset of sub-pages related to privacy value proposition, the prominent menu items in dropdown nav need removing — thus making all the columns rather uneven. I'm reshuffling the contents to move from 4-row grid to 3-row.
Significant changes and points to review
protocol_assetsIssue / Bugzilla link
Fixes #14458
Refs #14248
Testing
👇 👇 👇