Add l10n for Klar (Focus) branding #14490
Conversation
| // define '.mzp-t-product-klar' until https://github.com/mozilla/protocol/issues/930 | ||
| &.mzp-t-product-focus.mzp-t-product-klar { | ||
| background-image: url('/media/protocol/img/logos/firefox/browser/klar/logo-word-hor.svg'); | ||
| } |
There was a problem hiding this comment.
I've opened an issue upstream:
that is not too hard to resolve, so once/if confirmed as valid and not intentional wontfix, I might do the fix there, but until resolved, released and updated here, this is the least painful shim.
| srcset={ | ||
| 'img/firefox/browsers/mobile/index/firefox-focus-high-res.jpg': '2x' | ||
| 'img/firefox/mobile/firefox-focus-high-res.jpg': '2x' |
There was a problem hiding this comment.
I have left the default imgs in their original location too for now, but wondering what's the best practice? Remove them and keep only in l10/en-US? (I'd ideally symlink them, from img/l10n/en-US/* to img/firefox/browsers/*, but not sure how the tooling likes that…)
|
Thank you for bringing this to light!!! I suggest you convert this PR to draft for now, and we can update it when the Protocol changes come in. |
| @@ -57,7 +57,7 @@ | |||
| media_include='firefox/browsers/mobile/includes/s2d-focus.html', | |||
| media_after=True | |||
| ) %} | |||
| <div class="mzp-c-wordmark mzp-t-wordmark-md mzp-t-product-focus">{{ ftl('mobile-focus-firefox-focus') }}</div> | |||
| <div class="mzp-c-wordmark mzp-t-wordmark-md mzp-t-product-focus{% if LANG=='de' %} mzp-t-product-klar{% endif %}">{{ ftl('mobile-focus-firefox-focus') }}</div> | |||
There was a problem hiding this comment.
To Do: If this is waiting for mozilla/protocol#932 before merging, please don't put both mzp-t-product-focus and mzp-t-product-klar on the element together. Focus could over-write klar if the includes are in the wrong order.
| <div class="mzp-c-wordmark mzp-t-wordmark-md mzp-t-product-focus{% if LANG=='de' %} mzp-t-product-klar{% endif %}">{{ ftl('mobile-focus-firefox-focus') }}</div> | |
| <div class="mzp-c-wordmark mzp-t-wordmark-md {% if LANG=='de' %} mzp-t-product-klar{% else %}mzp-t-product-focus{% endif %}">{{ ftl('mobile-focus-firefox-focus') }}</div> |
One-line summary
Enables l10n for Focus screenshot on landing page, and locally adds a missing Protocol class for the wordmark.
Significant changes and points to review
(see notes below)
Issue / Bugzilla link
Fixes #14489
Testing
http://localhost:8000//de/firefox/browsers/mobile/focus/
http://localhost:8000/de/firefox/browsers/mobile/