Skip to content

Commit

Permalink
rustc: Don't copy in add_used_link_args
Browse files Browse the repository at this point in the history
  • Loading branch information
z0w0 committed Feb 17, 2013
1 parent 19eb225 commit 0991437
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/librustc/metadata/creader.rs
Expand Up @@ -196,7 +196,7 @@ fn visit_item(e: @mut Env, i: @ast::item) {
for link_args.each |a| {
match attr::get_meta_item_value_str(attr::attr_meta(*a)) {
Some(ref linkarg) => {
cstore::add_used_link_args(cstore, (/*bad*/copy *linkarg));
cstore::add_used_link_args(cstore, *linkarg);
}
None => {/* fallthrough */ }
}
Expand Down
2 changes: 1 addition & 1 deletion src/librustc/metadata/cstore.rs
Expand Up @@ -119,7 +119,7 @@ pub fn get_used_libraries(cstore: @mut CStore) -> ~[~str] {
return /*bad*/copy cstore.used_libraries;
}

pub fn add_used_link_args(cstore: @mut CStore, args: ~str) {
pub fn add_used_link_args(cstore: @mut CStore, args: &str) {
cstore.used_link_args.push_all(str::split_char(args, ' '));
}

Expand Down

5 comments on commit 0991437

@bors
Copy link
Contributor

@bors bors commented on 0991437 Feb 18, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 0991437 Feb 18, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging z0w0/rust/issue-1301 = 0991437 into auto

@bors
Copy link
Contributor

@bors bors commented on 0991437 Feb 18, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

z0w0/rust/issue-1301 = 0991437 merged ok, testing candidate = 1171a21

@bors
Copy link
Contributor

@bors bors commented on 0991437 Feb 18, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 0991437 Feb 18, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding incoming to auto = 1171a21

Please sign in to comment.