Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Prefer implemented traits in suggestions.
If `a.method();` can't be resolved, we first look for implemented traits globally and suggest those. If there are no such traits found, we only then fall back to suggesting from the unfiltered list of traits.
- Loading branch information
Showing
5 changed files
with
148 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0a55aac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from nikomatsakis
at huonw@0a55aac
0a55aac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging huonw/rust/trait-suggestions = 0a55aac into auto
0a55aac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
status: {"merge_sha": "ed530d7a3b67989047e6fe61fe101b9d8158585f"}
0a55aac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huonw/rust/trait-suggestions = 0a55aac merged ok, testing candidate = ed530d7
0a55aac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/3173
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/3166
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3168
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/3158
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3158
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/3161
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3154
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3148
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2827
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2825
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1663
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1655
0a55aac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = ed530d7
0a55aac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = ed530d7