Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
std: Turn down the stdout chunk size
I've found that 64k is still too much and continue to see the errors as reported in #14940. I've locally found that 32k fails, and 24k succeeds, so I've trimmed the size down to 8192 which libuv happens to use as well. It sounds like the limit can still be hit with many threads in play, but I have yet to reproduce this, so I figure we can wait until that's hit (if it's possible) and then take action.
- Loading branch information
198030f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from brson
at alexcrichton@198030f
198030f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging alexcrichton/rust/windows-large-console-write = 198030f into auto
198030f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alexcrichton/rust/windows-large-console-write = 198030f merged ok, testing candidate = e59e12ab
198030f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-win64-64-nopt-c/builds/83
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1253
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1252
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1252
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1253
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1247
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1246
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1247
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1251
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1246
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1246
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1250
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-t/builds/83
exception: http://buildbot.rust-lang.org/builders/auto-win64-64-opt/builds/83
198030f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from brson
at alexcrichton@198030f
198030f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging alexcrichton/rust/windows-large-console-write = 198030f into auto
198030f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alexcrichton/rust/windows-large-console-write = 198030f merged ok, testing candidate = a46fd016
198030f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-win32-32-opt/builds/84
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1254
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1253
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1253
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1254
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1248
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1247
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1248
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1252
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1247
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1247
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1251
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-t/builds/84
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-c/builds/84
198030f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from brson
at alexcrichton@198030f
198030f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging alexcrichton/rust/windows-large-console-write = 198030f into auto
198030f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alexcrichton/rust/windows-large-console-write = 198030f merged ok, testing candidate = 325808a
198030f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1255
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1254
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1254
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1255
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1249
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1248
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1249
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1253
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1248
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1248
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1252
success: http://buildbot.rust-lang.org/builders/auto-win32-32-opt/builds/85
success: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-t/builds/85
success: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-c/builds/85
success: http://buildbot.rust-lang.org/builders/auto-win64-64-opt/builds/85
success: http://buildbot.rust-lang.org/builders/auto-win64-64-nopt-t/builds/85
success: http://buildbot.rust-lang.org/builders/auto-win64-64-nopt-c/builds/85
198030f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 325808a