Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
enable jemalloc debugging in unoptimized builds
The performance hit from these checks is significant, but unoptimized builds are already incredibly slow. Enabling these checks results in better test coverage since there are bots doing unoptimized builds, and the cost is relatively small in the context of an unoptimized build. This also allows using `JEMALLOC_FLAGS` to override the default configure flags.
- Loading branch information
1 parent
4067252
commit 1ee099d
Showing
3 changed files
with
6 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ee099d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at https://github.com/thestinger/rust/commit/1ee099da36f6ac647747806558e555c5fe8dcd12
1ee099d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging thestinger/rust/jemalloc = 1ee099d into auto
1ee099d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thestinger/rust/jemalloc = 1ee099d merged ok, testing candidate = 9969e8a5
1ee099d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1263
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1265
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1264
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1264
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1265
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1259
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1258
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1259
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1258
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1258
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1262
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-opt/builds/95
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-t/builds/95
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-c/builds/95
exception: http://buildbot.rust-lang.org/builders/auto-win64-64-opt/builds/95
exception: http://buildbot.rust-lang.org/builders/auto-win64-64-nopt-t/builds/95
exception: http://buildbot.rust-lang.org/builders/auto-win64-64-nopt-c/builds/95
1ee099d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at https://github.com/thestinger/rust/commit/1ee099da36f6ac647747806558e555c5fe8dcd12
1ee099d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging thestinger/rust/jemalloc = 1ee099d into auto
1ee099d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thestinger/rust/jemalloc = 1ee099d merged ok, testing candidate = 0bbc6cee
1ee099d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1259
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1266
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1265
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1265
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1266
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1260
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1259
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1260
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1264
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1259
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1263
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-opt/builds/96
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-t/builds/96
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-c/builds/96
exception: http://buildbot.rust-lang.org/builders/auto-win64-64-opt/builds/96
exception: http://buildbot.rust-lang.org/builders/auto-win64-64-nopt-t/builds/96
exception: http://buildbot.rust-lang.org/builders/auto-win64-64-nopt-c/builds/96
1ee099d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at https://github.com/thestinger/rust/commit/1ee099da36f6ac647747806558e555c5fe8dcd12
1ee099d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging thestinger/rust/jemalloc = 1ee099d into auto
1ee099d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thestinger/rust/jemalloc = 1ee099d merged ok, testing candidate = 7ab58f6
1ee099d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1267
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1266
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1266
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1267
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1261
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1260
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1261
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1265
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1260
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1260
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1264
success: http://buildbot.rust-lang.org/builders/auto-win32-32-opt/builds/97
success: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-t/builds/97
success: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-c/builds/97
success: http://buildbot.rust-lang.org/builders/auto-win64-64-opt/builds/97
success: http://buildbot.rust-lang.org/builders/auto-win64-64-nopt-t/builds/97
success: http://buildbot.rust-lang.org/builders/auto-win64-64-nopt-c/builds/97
1ee099d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 7ab58f6