Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
typeck: Make the supplied parameters to be a tuple
When a type error occurs, check_method_argument_types() tries to provide arguments filled with ty::mk_err(). However, if a function takes the parameters as a tuple, the arguments should be converted to a tuple before being passed to check_argument_types(). Fixes #19521.
- Loading branch information
Showing
2 changed files
with
22 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
#![feature(unboxed_closures)] | ||
|
||
fn main() { | ||
"".homura()(); //~ ERROR does not implement any method | ||
} |
21d12c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from jakub
at barosl@21d12c0
21d12c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging barosl/rust/typeck-tupled-arguments-ice = 21d12c0 into auto
21d12c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
barosl/rust/typeck-tupled-arguments-ice = 21d12c0 merged ok, testing candidate = fddec2d
21d12c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2639
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2635
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/2627
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2635
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2626
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/2624
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2625
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2629
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/2621
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2621
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2621
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2288
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2285
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/2290
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1127
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1121
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/1117
21d12c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = fddec2d