Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
libstd: Limit Duration range to i64 milliseconds.
This enables `num_milliseconds` to return an `i64` again instead of `Option<i64>`, because it is guaranteed not to overflow. The Duration range is now rougly 300e6 years (positive and negative), whereas it was 300e9 years previously. To put these numbers in perspective, 300e9 years is about 21 times the age of the universe (according to Wolfram|Alpha). 300e6 years is about 1/15 of the age of the earth (according to Wolfram|Alpha).
- Loading branch information
Showing
4 changed files
with
52 additions
and
54 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26af5da
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from brson
at ruuda@26af5da
26af5da
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging ruud-v-a/rust/duration-reform = 26af5da into auto
26af5da
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ruud-v-a/rust/duration-reform = 26af5da merged ok, testing candidate = 5bd45177
26af5da
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1017
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1017
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1017
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1012
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1012
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1018
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1012
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1015
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1014