syntax: fix span for obsolete extern visibility error

rust-lang · Jul 26, 2013 · 2a18c29 · 2a18c29 · bors · Jul 27, 2013
1 parent 5109ce6
commit 2a18c29
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/libsyntax/parse/parser.rs b/src/libsyntax/parse/parser.rs
@@ -4196,7 +4196,7 @@ impl Parser {
 
             // Do not allow visibility to be specified.
             if visibility != ast::inherited {
-                self.obsolete(*self.span, ObsoleteExternVisibility);
+                self.obsolete(*self.last_span, ObsoleteExternVisibility);
             }
 
             let abis = opt_abis.get_or_default(AbiSet::C());

diff --git a/src/test/compile-fail/obsolete-syntax.rs b/src/test/compile-fail/obsolete-syntax.rs
@@ -63,4 +63,14 @@ fn obsolete_moves() {
     //~^ ERROR obsolete syntax: binary move
 }
 
+extern mod obsolete_name {
+    //~^ ERROR obsolete syntax: named external module
+    fn bar();
+}
+
+pub extern {
+    //~^ ERROR obsolete syntax: `pub extern`
+    pub fn bar();
+}
+
 fn main() { }