Skip to content

Commit

Permalink
stop disabling ASLR in normal Windows builds
Browse files Browse the repository at this point in the history
Closes #16514
  • Loading branch information
thestinger committed Sep 18, 2014
1 parent 9508faa commit 360a29d
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/librustc/back/link.rs
Expand Up @@ -1024,7 +1024,9 @@ fn link_args(cmd: &mut Command,

// Mark all dynamic libraries and executables as compatible with ASLR
// FIXME #17098: ASLR breaks gdb
// cmd.arg("-Wl,--dynamicbase");
if sess.opts.debuginfo == NoDebugInfo {
cmd.arg("-Wl,--dynamicbase");
}

// Mark all dynamic libraries and executables as compatible with the larger 4GiB address
// space available to x86 Windows binaries on x86_64.
Expand Down

12 comments on commit 360a29d

@bors
Copy link
Contributor

@bors bors commented on 360a29d Sep 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 360a29d Sep 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging thestinger/rust/aslr = 360a29d into auto

@bors
Copy link
Contributor

@bors bors commented on 360a29d Sep 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thestinger/rust/aslr = 360a29d merged ok, testing candidate = e697b041

@bors
Copy link
Contributor

@bors bors commented on 360a29d Sep 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 360a29d Sep 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 360a29d Sep 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging thestinger/rust/aslr = 360a29d into auto

@bors
Copy link
Contributor

@bors bors commented on 360a29d Sep 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thestinger/rust/aslr = 360a29d merged ok, testing candidate = a116036b

@bors
Copy link
Contributor

@bors bors commented on 360a29d Sep 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 360a29d Sep 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 360a29d Sep 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging thestinger/rust/aslr = 360a29d into auto

@bors
Copy link
Contributor

@bors bors commented on 360a29d Sep 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thestinger/rust/aslr = 360a29d merged ok, testing candidate = ffbdc591

@bors
Copy link
Contributor

@bors bors commented on 360a29d Sep 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.