Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
stop disabling ASLR in normal Windows builds
Closes #16514
- Loading branch information
Closes #16514
360a29d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at https://github.com/thestinger/rust/commit/360a29d9c93086fe34222c42b59f46ab6e0fb14c
360a29d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging thestinger/rust/aslr = 360a29d into auto
360a29d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thestinger/rust/aslr = 360a29d merged ok, testing candidate = e697b041
360a29d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1432
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1433
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1432
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1431
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1429
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1428
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1428
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1432
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1426
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1426
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1429
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-opt/builds/264
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-t/builds/264
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-c/builds/264
exception: http://buildbot.rust-lang.org/builders/auto-win64-64-opt/builds/264
exception: http://buildbot.rust-lang.org/builders/auto-win64-64-nopt-t/builds/264
exception: http://buildbot.rust-lang.org/builders/auto-win64-64-nopt-c/builds/264
360a29d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at https://github.com/thestinger/rust/commit/360a29d9c93086fe34222c42b59f46ab6e0fb14c
360a29d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging thestinger/rust/aslr = 360a29d into auto
360a29d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thestinger/rust/aslr = 360a29d merged ok, testing candidate = a116036b
360a29d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1434
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1435
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1434
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1433
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1431
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1430
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1430
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1434
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1428
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1428
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1431
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-opt/builds/266
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-t/builds/266
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-c/builds/266
exception: http://buildbot.rust-lang.org/builders/auto-win64-64-opt/builds/266
exception: http://buildbot.rust-lang.org/builders/auto-win64-64-nopt-t/builds/266
exception: http://buildbot.rust-lang.org/builders/auto-win64-64-nopt-c/builds/266
360a29d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at https://github.com/thestinger/rust/commit/360a29d9c93086fe34222c42b59f46ab6e0fb14c
360a29d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging thestinger/rust/aslr = 360a29d into auto
360a29d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thestinger/rust/aslr = 360a29d merged ok, testing candidate = ffbdc591
360a29d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1435
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1437
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1436
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1436
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1433
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1432
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1432
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1436
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1430
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1430
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1433
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-opt/builds/268
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-t/builds/268
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-c/builds/268
exception: http://buildbot.rust-lang.org/builders/auto-win64-64-opt/builds/268
exception: http://buildbot.rust-lang.org/builders/auto-win64-64-nopt-t/builds/268
exception: http://buildbot.rust-lang.org/builders/auto-win64-64-nopt-c/builds/268