Skip to content

Commit

Permalink
Don't try to suggest fields of an enum
Browse files Browse the repository at this point in the history
Fixes #24365
  • Loading branch information
arielb1 committed Apr 13, 2015
1 parent b9ed9e2 commit 39543e9
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/librustc_typeck/check/mod.rs
Expand Up @@ -2691,8 +2691,8 @@ fn check_expr_with_unifier<'a, 'tcx, F>(fcx: &FnCtxt<'a, 'tcx>,
actual)
},
expr_t, None);
if let Some(t) = ty::ty_to_def_id(expr_t) {
suggest_field_names(t, field, tcx, vec![]);
if let ty::ty_struct(did, _) = expr_t.sty {
suggest_field_names(did, field, tcx, vec![]);
}
}

Expand Down
29 changes: 29 additions & 0 deletions src/test/compile-fail/issue-24365.rs
@@ -0,0 +1,29 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

pub enum Attribute {
Code {attr_name_idx: u16},
}

pub enum Foo {
Bar
}

fn test(a: Foo) {
println!("{}", a.b); //~ ERROR attempted access of field
}

fn main() {
let x = Attribute::Code {
attr_name_idx: 42,
};
let z = (&x).attr_name_idx; //~ ERROR attempted access of field
let y = x.attr_name_idx; //~ ERROR attempted access of field
}

0 comments on commit 39543e9

Please sign in to comment.